remove double initialization behavior

sotopia-lab / sotopia

Sotopia: an Open-ended Social Learning Environment (ICLR 2024 spotlight)

https://docs.sotopia.world

MIT License

127 stars 16 forks source link

remove double initialization behavior #86

Open XuhuiZhou opened 1 month ago

XuhuiZhou commented 1 month ago

Closes #

📑 Description

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed
[ ] Branch name follows type/descript (e.g. feature/add-llm-agents)
[ ] Ready for code review

ℹ Additional Information

ProKil commented 1 month ago

This would break the RedisAgent initialization. In our previous implementation, RedisAgent will be first initialized as an LLMAgent and reinitialized as RedisAgent, which is not ideal. After you delete the reinitialization snippet, this is broken.

Please change this get_agent_class accordingly.

XuhuiZhou commented 4 weeks ago

This would break the RedisAgent initialization. In our previous implementation, RedisAgent will be first initialized as an LLMAgent and reinitialized as RedisAgent, which is not ideal. After you delete the reinitialization snippet, this is broken.

Please change this get_agent_class accordingly.

@ProKil can you point out to me which line of code is causing the error?

ProKil commented 3 weeks ago

https://github.com/sotopia-lab/sotopia/blob/1cde9ec7e1785cbdb471b2ebef65300e9d8f78a0/sotopia/server.py#L258

RedisAgent is not dealt with here.