search

soulhotel / FF-ULTIMA

The Firefox theme with too many options.. FF Ultima.
Mozilla Public License 2.0
592 stars 23 forks source link

[Enhancement] Colors need adjustment - for when using an Add-On Theme #182

Open dreadbalaur opened 3 days ago

dreadbalaur commented 3 days ago

Already looked at the Wiki? - https://github.com/soulhotel/FF-ULTIMA/wiki

Yes

Describe the issue:

Firefox's Alpenglow is a unique beast: it is a native theme that follows the system theme, but even in its light mode there are some dark elements in the UI, namely the burger menu and the address bar.

I don't know how Firefox managed Alpenglow's coding to achieve that in the first place, but all Ultima themes force a light color change to the menu, effectively making the menu illegible in Alpenglow light mode. Default theme makes it transparent, dusky makes it white, and gruvbox light makes it orange.

Expected behavior:

Ideally a way for these dark-UI elements to come back when using Alpenglow?

Platform/Desktop:

Picture | Video: With Ultima Dusky image Without Ultima image

soulhotel commented 3 days ago

https://github.com/user-attachments/assets/1f320ca6-8403-4d51-8df6-6c9ab5f8551a

I see what you mean, I haven't looked into it yet but it's definitely because of the freedom that themes have to use color variables however they wish, chaos.

I'll rewrite global-theming (for when addon themes are in use) and override those variables, easy solution, tomorrow night though. When I do make these updates it'll be in the next releases source + changelog, since this release is still 10 days away. Hopefully this will become a one-for-all solution. Until then.

soulhotel commented 23 hours ago

https://github.com/user-attachments/assets/8944d9c5-9b21-4a60-9bbf-96c20b713c09

change log, update-branch was just updated, pre-release for FF Ultima 1.9.3 most likely tomorrow.