Frontend: Update gulp-sass as to support Node v16

souramoo / commentoplusplus

Commento with out of the box patches and updates to add useful features and fixes. Also with one-click deploy to Heroku so you can get up and running fast.

MIT License

389 stars 62 forks source link

Frontend: Update gulp-sass as to support Node v16 #91

Closed olof-nord closed 2 years ago

olof-nord commented 2 years ago

Current version of node-sass prevents building with Node v16 (it would be nice to update to the last LTS), so let's use Node v14 for now.

The frontend package is using v4.0.1 of the library, the most current version is v5.1.0.

See PR #89 for the full details.

Wonderfall commented 2 years ago

~~Also worth noting that node-sass itself, while still maintained at the moment, seems deprecated.~~

Nevermind, but sass should probably be updated too to support Node 16. It's also quite outdated.

souramoo commented 2 years ago

Thanks for flagging this; fixed in edc2a92! :) This was also needed to ensure things would compile on github actions for CI purposes as they have node v16 too.