fix: achievements loading and assessment workspace 404 - Githubissues

source-academy / frontend

Frontend of Source Academy, an online experiential environment for computational thinking (React, Redux, Saga, Blueprint)

https://sourceacademy.org

Apache License 2.0

103 stars 167 forks source link

fix: achievements loading and assessment workspace 404 #3073

Closed RichDom2185 closed 3 weeks ago

RichDom2185 commented 3 weeks ago

Description

Closes #3072.

Also fixes a small bug following #3061 so that updated achievements can be redisplayed in the frontend when the backend returns with fresh data.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

How to test

Checklist

[x] I have tested this code
[ ] I have updated the documentation

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 11566119996

Details

1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
3 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.007%) to 31.335%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/commons/assessmentWorkspace/AssessmentWorkspace.tsx	1	2	50.0%
<!--	Total:	1	2	50.0%	-->

Files with Coverage Reduction	New Missed Lines	%
src/commons/assessmentWorkspace/AssessmentWorkspace.tsx	1	64.57%
src/commons/application/actions/SessionActions.ts	1	80.0%
src/pages/achievement/control/AchievementControl.tsx	1	0.0%
<!--	Total:	3		-->

Totals
Change from base Build 11565577526:	-0.007%
Covered Lines:	4833
Relevant Lines:	14552

💛 - Coveralls