sourcegraph / go-sourcegraph

https://sourcegraph.com/github.com/sourcegraph/go-sourcegraph
MIT License
42 stars 9 forks source link

accept all TLS certs for localhost #57

Closed neelance closed 9 years ago

gbbr commented 9 years ago

I am not familiar with the context, but in terms of code LGTM

neelance commented 9 years ago

The idea is to allow localhost connections regardless of the certificate used, because the cert is usually only valid for the external domain.

gbbr commented 9 years ago

Do you wanna add a map of localhost, 127.0.0.1, ::1 just in case? Would that be a better idea? Is there a way we can cover more variations of localhost?

keegancsmith commented 9 years ago

shipit. localhost should be good enough. In fact after a quick check there are even places in net/http code where they just check localhost.

gbbr commented 9 years ago

:shipit: