search

sourcegraph / go-sourcegraph

https://sourcegraph.com/github.com/sourcegraph/go-sourcegraph
MIT License
42 stars 9 forks source link

Generic storage #75

Closed slimsag closed 9 years ago

slimsag commented 9 years ago

This change provides a generic storage API, more details in the core repo CS.

slimsag commented 9 years ago

@shurcooL I fixed the enum style and also used a bit less for the docstring you commented on. Your points are well received :)

dmitshur commented 9 years ago

In terms of actual content, this looks good. There are just documentation style inconsistencies with the rest of the document. I've pointed out a few, but it's pretty much everywhere except the part you've addressed recently.

In light of #83, I'm not sure how important it is to address these. I'll leave it to you. I just wanted to point out the inconsistency so you'd be aware.

Also minor typo (maybe?) at https://github.com/sourcegraph/go-sourcegraph/commit/86964c17f2128008964a9b6e644ba944419d6180#commitcomment-14145903.

Otherwise this LGTM.

slimsag commented 9 years ago

@shurcooL can confirm these commits addressed your concerns?

dmitshur commented 9 years ago

Yes, thanks! LGTM.