Enable Apollo-Client in browser extension background script

sourcegraph / sourcegraph-public-snapshot

Code AI platform with Code Search & Cody

https://sourcegraph.com

Other

10.12k stars 1.29k forks source link

Enable Apollo-Client in browser extension background script #24953

Open valerybugakov opened 3 years ago

valerybugakov commented 3 years ago

Context

Apollo-Client is not configured yet to execute requests in the background script. We fallback to requestGraphQLInBackground when client.watchQuery is called.

A follow-up for the PR that enabled Apollo-Client for extensions query.

Changes required

We need to implement a bridge similar to background.requestGraphQL or update browser extension integration tests to allow fetching data in the main thread.

github-actions[bot] commented 3 years ago

Heads up @joelkw @muratsu - the "team/extensibility" label was applied to this issue.

vdavid commented 2 years ago

@valerybugakov what'd be the benefit of using Apollo-Client here? (@philipp-spiess and I just got here after a year haha 😅 )