sourcegraph / stylelint-config

Shared stylelint config for all Sourcegraph projects
Apache License 2.0
4 stars 4 forks source link

Custom Stylelint rule to ban BEM convention in CSS modules #131

Open valerybugakov opened 3 years ago

valerybugakov commented 3 years ago

Problem statement

This summer we started the migration to CSS modules in the main Sourcegraph monorepo. We decided not to use the BEM convention in CSS modules apart from modifier selectors:

// Global CSS
.repo-header {
  &--active  { ... }
  &__button { ... }
}

// CSS module
.repo-header {
  &--active  { ... }
}

.button { ... }

Notice how we keep a nested modifier selector &--active. But the &__button selector is bubbled to the top level. To stick to this convention, we need a Stylelint rule to ban usage on &__* selectors in CSS modules.

Success criteria

  1. A custom Stylelint rule is created that warns if the &__* selector is used.
  2. It's added to our Stylelint config as a glob-based rule to apply it only to *.module.scss files.

Things to learn/practice during the implementation

Writing custom Stylelint rules to keep the codebase consistent.

Estimated amount of work

T-shirt size estimate: M.

oleggromov commented 2 years ago

I absolutely love the title. Will work on it! 😍