search

sourcerer-io / sourcerer-app

🦄 Sourcerer app makes a visual profile from your GitHub and git repositories.
https://sourcerer.io/start
MIT License
6.74k stars 280 forks source link

Support for Svelte #523

Closed edgarberlinck closed 5 years ago

edgarberlinck commented 5 years ago

Hi. Have you guys any plan to support Svelte (https://svelte.dev/)?

sergey48k commented 5 years ago

We don't but if it's just detecting extension, it should not be too hard. @yaronskaya , what do you think?

edgarberlinck commented 5 years ago

I'm trying to do, but I don't understand some points of your code.

I did the same logic at JavascriptExtractor to detect .svelte files just like Vue files. I think it should work after I create a js.svelte property at awesomeLibs files.

My problem is: The tests are not passing. Can you guys take a look at my code? Maybe I'm close to do it.

https://github.com/edgarberlinck/sourcerer-app/commit/8ec8c2b84c75821422893f9837d2550a24bedcbc

yaronskaya commented 5 years ago

Hi @edgarberlinck, first of all add the library to sourcerer-io/awesome-libraries so that it to be indexed to be shown in the profile. Also add a test like this. Your code passes tests for me.

edgarberlinck commented 5 years ago

Nice. Thanks for your help @yaronskaya, that helps me alot!

My pull requests are ready, I think everything is ok. Glad to contribute to this amazing tool.