sourcery-ai / sourcery

Instant AI code reviews
https://sourcery.ai
MIT License
1.5k stars 65 forks source link

Sourcery GitHub app returns no status if no refactorings have been found #424

Closed cesarcoatl closed 3 months ago

cesarcoatl commented 3 months ago

Checklist

Description

I have authorized and configured Sourcery as required for PRs before they're merged, but since January 22 this check does not return a status if no refactoring has been found and it's blocking auto-merge, leaving me with two options:

  1. Merge as an administrator
  2. Remove Sourcery from required status checks

Now sourcery-ai-bot simply leaves a comment on PRs, which are useful, but returns no status and remains as "Expected".

brendanator commented 3 months ago

Hi @thecesrom, we've changed the process of reviews to produce reviews directly on the PR, and removed this check status. If future Sourcery will make approval / request changes decisions on PRs which will replace this check status

For now though, the best solution is to remove Sourcery from the required status checks