search

sous-chefs / firewall

Development repository for the firewall cookbook
https://supermarket.chef.io/cookbooks/firewall
Apache License 2.0
99 stars 150 forks source link

Release please #157

Closed axos88 closed 7 years ago

axos88 commented 7 years ago

A critical bug concerning service names on windows has been fixed. Please release a patch version so that we can use it.

https://github.com/chef-cookbooks/firewall/commit/dd39b95a712234fcbcd6db053fde3ced6186db2d#diff-836805b7b36b8449cb3588e8b8eb3fc0R63

Thanks,

martinb3 commented 7 years ago

@axos88 That change was made in July, and our last release was October. The fix should already be available. /CC @snkutlu

axos88 commented 7 years ago

It doesn't seem that way: https://github.com/chef-cookbooks/firewall/blob/v2.5.3/libraries/helpers_windows.rb#L63

martinb3 commented 7 years ago

Ah, I see -- it's dated July 20th, but wasn't merged until later in October. 👍

martinb3 commented 7 years ago

I've released v2.5.4. Thank you for the ping! :)