Allow Optional Comments

pwelch commented 6 years ago

Description

Allow iptable rule comments to be excluded with a flag. Sometimes it might be necessary to not have a comment for a given rule.

Issues Resolved

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

martinb3 commented 6 years ago

Hi @pwelch -- thanks for this! I think the only thing missing is a test for omitting comments. Doesn't have to be much, but I figure we should probably include something, just so we don't break it in the future.

Maybe mark one of the existing test cookbook rules as include_comment false, and update the test for it to be sure?

pwelch commented 6 years ago

@martinb3 added a test on 0e6b024

sous-chefs / firewall