Closed sw-joelmut closed 1 month ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
libraries/botframework-connector/src/auth/federatedAppCredentials.ts | 5 | 15 | 33.33% | ||
libraries/botframework-connector/src/auth/federatedServiceClientCredentialsFactory.ts | 4 | 15 | 26.67% | ||
<!-- | Total: | 12 | 33 | 36.36% | --> |
Totals | |
---|---|
Change from base Build 11168214507: | -0.1% |
Covered Lines: | 20444 |
Relevant Lines: | 22942 |
/promoted 4765
Fixes # 4632
minor
Ported from https://github.com/microsoft/botbuilder-dotnet/pull/ 6838
Description
This PR ports the Federated Credentials from DotNet's repo. The implementation is similar except in the
fetchExternalToken
, since it requires the Audience value to be provided, by default it uses 'api://AzureADTokenExchange'.Specific Changes
Bot usage example
Testing
As we FIC isn't available for third-party apps, we encountered the following error (same error when testing DotNet's implementation).