southworks / botbuilder-js

JavaScript SDK used to build chat bots for the Microsoft Bot Framework.
MIT License
1 stars 3 forks source link

refactor: [#4684] Replace browserify with tsup #487

Closed sw-joelmut closed 1 month ago

sw-joelmut commented 1 month ago

Addresses # 4684

minor

Description

This PR removes browserify from the repo and replaces it with tsup.

Specific Changes

Testing

The following image shows the browser import logs, and the browser-echo-bot working. image image

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11577449899

Details


Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/disassemblers/httpContentStreamDisassembler.ts 1 90.0%
libraries/botframework-streaming/src/disassemblers/requestDisassembler.ts 1 63.89%
libraries/botframework-streaming/src/payloads/streamManager.ts 1 73.17%
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 1 68.6%
libraries/botframework-streaming/src/payloadTransport/payloadSender.ts 1 77.42%
libraries/botframework-streaming/src/payloads/requestManager.ts 1 86.67%
libraries/botframework-streaming/src/disassemblers/responseDisassembler.ts 1 77.78%
libraries/botframework-streaming/src/payloadTransport/payloadReceiver.ts 1 78.87%
libraries/botframework-streaming/src/disassemblers/payloadDisassembler.ts 2 87.5%
libraries/botframework-streaming/src/protocolAdapter.ts 3 85.71%
<!-- Total: 23 -->
Totals Coverage Status
Change from base Build 11576118242: -0.5%
Covered Lines: 20514
Relevant Lines: 23063

💛 - Coveralls
ceciliaavila commented 1 month ago

Just a typo in the PR's description: btoframework-streaming

sw-joelmut commented 1 month ago

/promoted 4774