southworks / botbuilder-js

JavaScript SDK used to build chat bots for the Microsoft Bot Framework.

MIT License

1 stars 3 forks source link

fix: ESLint issues in botbuilder-dialogs #506

Open JhontSouth opened 1 month ago

JhontSouth commented 1 month ago

Addresses # 4684

minor

Description

This PR fixes the new errors and warnings incoming in the latest version of ESLint packages in botbuilder-dialogs.

Specific Changes

Removed eslint.config.cjs file.
Fixed ESLint issues by running --fix flag.
Added missing documentation and removed unnecessary spaces.
Added some skips to rules that don't follow the current logic.
Removed duplicated unit test and combined logic of these two.

Testing

The following image shows the lint command running without problems in botbuilder-dialogs.

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 11840641101

Details

18 of 18 (100.0%) changed or added relevant lines in 14 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 84.703%

Totals
Change from base Build 11691458662:	-0.001%
Covered Lines:	20514
Relevant Lines:	23063

💛 - Coveralls