southworks / botbuilder-js

JavaScript SDK used to build chat bots for the Microsoft Bot Framework.

MIT License

1 stars 3 forks source link

bump: [#4684] Upgrade chai using import-sync for esm-only package #522

Closed sw-joelmut closed 2 weeks ago

sw-joelmut commented 4 weeks ago

Addresses # 4684

minor

Description

This PR updates the chai package to its latest version 5.1.2. Starting on version 5.x, this package is ESM-only, so we used import-sync to be able to use this version.

Specific Changes

Updated chai from 4.5.0 and 5.1.2 in botbuilder and botframework-streaming libraries.
Added import-sync as a dependency in botbuilder and botframework-streaming.
Added chai to the depcheck ignore list as it threw a false positive on unused dependency.

Testing

The following images show the installed version.

coveralls commented 4 weeks ago

Pull Request Test Coverage Report for Build 11635286373

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.704%

Totals
Change from base Build 11629352641:	0.0%
Covered Lines:	20515
Relevant Lines:	23064

💛 - Coveralls

sw-joelmut commented 2 weeks ago

/promoted 4792