sovietspaceship / souls-bug-reports

Bug reports for some of my apps (Elden Ring Build & Inventory Planner, Elden Ring Frame Data Explorer, Dark Souls III Inventory Tool, etc.)
https://nyasu.business
0 stars 0 forks source link

[Elden Ring Frame Data Explorer] Event Descriptions #28

Open A-q-p-W opened 1 year ago

A-q-p-W commented 1 year ago

Application

Is your feature request related to a problem? Please describe. Some events in the SpEffect category are not easy to understand the meaning of. For example, spEffectId 89 "Set Damage Level To 1...", spEffectId 32 "Does Not Allow Throws (Grab Attacks)" and spEffectId 144 "Jump Attack Landing Determination - Possible Heavy Landing"

Describe the solution you'd like I would like to see an explanation of certain events that are not self explanatory such as the ones listed above incorporated into the frame data viewer.

Describe alternatives you've considered If incorporating explanations or descriptions of events into the viewer is not practical, you could include an easy-to-find link to a relevant document or website that explains what the different events do and what they mean.

Additional context image image

sovietspaceship commented 1 year ago

There are many thousands of speffects in the game and none have descriptions in the game files, they need to be manually inspected and labelled. Effects like the first one are just references to SpEffectParam (which I guess I could parse to programmatically generate label names based on their values for those that aren't labelled in the app), but most speffects (like the second one) referenced by tae files are used by the behaviour script, and labelling those is a huge task. Only a portion has been labelled and I've merged several manually maintained definitions by the community for that, and we still don't know what many of these even do yet. For now there's no document to refer to, simply because there isn't much more information about these effects other than the framedata explorer, a couple google sheets and conversations in ?ServerName?.

What I can do realistically is updating the labels from time to time when my sources get updated.