search

sowawa / fluent-plugin-slack

132 stars 52 forks source link

fix: use image icon #11

Closed jwyjoy closed 9 years ago

jwyjoy commented 9 years ago

I did not experience. Ruby. But, I would like to use an image icon for my slack. can this merge? Do you have a similar plan this?

sonots commented 9 years ago

Test codes are required.

sonots commented 9 years ago

I understand your demand. I'm willing to merge.

jwyjoy commented 9 years ago

LOL! Thanks your quick advice :D I'll try. Test and keep icon_emoji as default.

jwyjoy commented 9 years ago

i'll fix some issues that the request again.

jwyjoy commented 9 years ago

look at this commit plz. [fix: use default icon emoji. But priority is given to the url] this commit. keep icon_emoji as default. edit on your advice

but, i can't edit test. if the two setting are no success. on slack set icon. Will that increase the source file? [ex) test_out_slack_url_icon.rb test_slack_client_url_icon.rb] Await your advice.

sonots commented 9 years ago

I will merge and then write a test for this. thanks!

sonots commented 9 years ago

Added tests and documents > https://github.com/sowawa/fluent-plugin-slack/commit/a8b729d217985da5f724d829559f7d3b9fc7b8bf

sonots commented 9 years ago

@jwyjoy released v0.5.2!

jwyjoy commented 9 years ago

yeah! tnk! @sonots :D