search

sowawa / fluent-plugin-slack

132 stars 52 forks source link

Support link_names, and parse options #15

Closed sonots closed 9 years ago

sonots commented 9 years ago

Support link_names, and parse options to enable Desktop Notification via Mention for Incoming Webhook and Slack Web API.

Following incompatibility changes were introduced:

  1. the default payload of Incoming Webhook was changed
  2. color is nil as default
  3. mrkdwn is true as default
  4. link_names is true as default
  5. icon_emoji is nil as default
  6. username is nil as default

\1. and 2. are because link_names=1 effectively works only for the text field, and not for the attachments field. color and title option requires to use attachments field.

\3. and 4. are just because I thought setting them by default reduces troubles which users will experience.

\5. and 6. are just incidentally.

sonots commented 9 years ago

In Japanese:

デフォルトで link_names=1 を利かせたかったので、下位互換性を壊しています。

link_names=1 にすると、Incoming Webhook および Slack Web API において、Mention による Desktop Notification が機能するのですが、以下の制限があります。

  1. attachments フィールドでは機能しない

そのため、attachments を使わざるを得ない color および title オプションをデフォルトで無効にしました。デフォルト値の下位互換性が壊れています．

sonots commented 9 years ago

I am supposed to release as v0.6.0

sowawa commented 9 years ago

I understand these changes and the effects. At least in my use case, I don't care. Accept these incompatibility, then we receive a number of advantages. I think it is acceptable to change them.

Let merge :+1:

sonots commented 9 years ago

v0.6.0 released

sowawa commented 9 years ago

:tada: