search

sowbug / groove

A digital audio workstation (DAW) engine.
Other
19 stars 0 forks source link

Pick normalized parameters wherever possible #130

Closed sowbug closed 1 year ago

sowbug commented 1 year ago

Take ADSR envelopes. Currently I'm storing ADR as seconds. That's inconvenient because the range is hardcoded; GUI controls need to know what 0/max correspond to, and if one instrument wants a different range, then that change needs to propagate all the way out to UI (and documentation, etc). If we instead store 0.0..=1.0, then the instrument can decide (even at runtime) what that maps to. That range can even itself be a configurable parameter!

sowbug commented 1 year ago

This is becoming a virtuous habit. I'll close when I've handled the envelope example in this issue.

sowbug commented 1 year ago

Moving to icebox rather than closing as a reminder. Maybe this should go into a coding-standards document.

sowbug commented 1 year ago

Ugh, I missed the point with ab5afb6551b5dd86dc0e6cd62a062afbe78d8b15. Fixing....