search

soynatan / django-easy-audit

Yet another Django audit log app, hopefully the simplest one.
GNU General Public License v3.0
743 stars 182 forks source link

BeautifulSoup Dependency #191

Open chemeng opened 3 years ago

chemeng commented 3 years ago

Why is beautifulsoup4 a dependency on the project? With some grepping I didn't see it being used anywhere.

jkarstens commented 3 years ago

Looks like it's used in TestAuditAdmin, test_request_event_admin_no_users https://github.com/soynatan/django-easy-audit/blob/860a556d0f9314e25d99904643c2a4e18c71aa51/easyaudit/tests/test_app/tests.py#L271

Seems nothing is done with it though - looks like it wouldn't be too bad to remove the bs4 dependency from the test case

mschoettle commented 3 months ago

This has been resolved in #267.

It's currently only available as a beta release but won't be present in the future anymore.