search

sp614x / optifine

1.8k stars 418 forks source link

[Resource Packs] Light maps for custom dimensions #7447

Open Gileneri opened 1 year ago

Gileneri commented 1 year ago

Being able to implement different Light maps into custom dimensions

Well the suggestion i have is to improve the light maps feature systems to better suit modded dimensions. Right now i noticed that you can only name your light map images as "world0", "world1" and "world-1" for the 3 Minecraft vanilla dimensions, but if you try naming them the ID name of a modded dimension (wich isnt numerical anymore), it doesnt work. I even noticed a bug where if youre using a custom light map for the overworld, it also spreads to other modded dimensions. Other issues around this are also at making custom sky boxes for modded dimensions and also upon adding shaders to them.

For reference, theres two mods that already have a better dimension ID system: Celestial (by Fishcute) and Colormatic (by kwertiTheCats), (colormatic only has a fabric version).

calreveraster commented 1 year ago

This seems to be a duplicate of https://github.com/sp614x/optifine/issues/7101

For some time now it has been suggested that a dimension.properties file be added to address the fact that dimensions are no longer numerical IDs

What happens in optifine (and in other shader programs as well), is that unless a dimension is defined in the shader program via numerical ID, it uses the overworld settings. However, since 1.16, when the new dimension system was added, there became no way to define numerical dimension IDs, so none of those dimensions will register. A dimensions.properties file would allow the shader pack dev to map a numerical ID to a dimension from within the shader. This is similar to how the block.properties file works.

Gileneri commented 1 year ago

Mmhh, but is that possible to make a dimensions.properties file? If so, how would I have to make that?

Em sex., 8 de set. de 2023 14:23, Calvin Reveraster < @.***> escreveu:

This seems to be a duplicate of #7101 https://github.com/sp614x/optifine/issues/7101

For some time now it has been suggested that a dimension.properties file be added to address the fact that dimensions are no longer numerical IDs

What happens in optifine (and in other shader programs as well), is that unless a dimension is defined in the shader program via numerical ID, it uses the overworld settings. However, since 1.16, when the new dimension system was added, there became no way to define numerical dimension IDs, so none of those dimensions will register. A dimensions.properties file would allow the shader pack dev to map a numerical ID to a dimension from within the shader. This is similar to how the block.properties file works.

— Reply to this email directly, view it on GitHub https://github.com/sp614x/optifine/issues/7447#issuecomment-1711998951, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYEDSRRQFTBDXL6HRRMCIA3XZNIADANCNFSM6AAAAAAZXIA6IM . You are receiving this because you authored the thread.Message ID: @.***>

calreveraster commented 1 year ago

Mmhh, but is that possible to make a dimensions.properties file? If so, how would I have to make that? Em sex., 8 de set. de 2023 14:23, Calvin Reveraster < @.> escreveu: … This seems to be a duplicate of #7101 <#7101> For some time now it has been suggested that a dimension.properties file be added to address the fact that dimensions are no longer numerical IDs What happens in optifine (and in other shader programs as well), is that unless a dimension is defined in the shader program via numerical ID, it uses the overworld settings. However, since 1.16, when the new dimension system was added, there became no way to define numerical dimension IDs, so none of those dimensions will register. A dimensions.properties file would allow the shader pack dev to map a numerical ID to a dimension from within the shader. This is similar to how the block.properties file works. — Reply to this email directly, view it on GitHub <#7447 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYEDSRRQFTBDXL6HRRMCIA3XZNIADANCNFSM6AAAAAAZXIA6IM . You are receiving this because you authored the thread.Message ID: @.>

sp614x would need to add the functionality to optifine first, this is not functionality that is currently in optifine (or any shader mod) - we just want it to be.

Once that functionality were added, a hypothetical dimension.properties file would theoretically be added to the shader pack, similar to the way the current block.properties file works.