space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.com
MIT License
2.74k stars 3.49k forks source link

Uploading YAML prototypes to server causes AI subroutine to bug out. #12402

Closed ZoldorfTheWizard closed 1 year ago

ZoldorfTheWizard commented 2 years ago

Description

Uploading YAML prototypes to server causes AI subroutine to bug out.

Reproduction Steps to reproduce: Create NPC using aI (Floppa) Upload custom yaml file, NPC stops moving.

happens to all custom loaded prototypes, whether they get loaded or not. here is what i used


  parent: BaseItem
  id: TESTCUSTOMYAML2
  name: TEST
  description: TEST
  components:
  - type: Sprite
    sprite: Objects/Misc/skub.rsi
    state: icon
  - type: Item
    sprite: Objects/Misc/skub.rsi
  - type: ItemCooldown```
Insineer commented 1 year ago

I couldn't reproduce it on current master. Tried with server-client on single machine running with Windows 11.

Maybe there are any exceptions in the server's console?

metalgearsloth commented 1 year ago

I couldn't reproduce it on current master. Tried with server-client on single machine running with Windows 11.

Maybe there are any exceptions in the server's console?

We already know the why and there is a potential PR up https://github.com/space-wizards/RobustToolbox/pull/3609

ZoldorfTheWizard commented 1 year ago

resolved by https://github.com/space-wizards/RobustToolbox/pull/3609