space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.74k stars 3.48k forks source link

thief beacon double counts items in nested containers #31337

Open deltanedas opened 3 months ago

deltanedas commented 3 months ago

Description

05:29:30

sporkyz commented 1 month ago

Notably, this bug allows the thief to win the relevant sub-objective at round end; it's not just a visual issue with the character menu.

sporkyz commented 1 month ago

There appear to be two sperate issues with the beacon.

First, it double counts items in containers: image Second, it counts items in the user's inventories again if they're within the stealArea of the beacon: image

If both of these problems happen at once (i.e., items stored within a bag, in the player's inventory, next to the beacon), both problems will compound and you'll get a triple-count: image

deltanedas commented 1 month ago

inventory is a container so that's to be expected

also i never said this was visual you can basically dupe items for the purpose of greentext

sporkyz commented 1 month ago

also i never said this was visual you can basically dupe items for the purpose of greentext

Yeah, didn't mean to imply you had. I'm mostly just documenting specifics because I'm working on a fix at the moment.

lzk228 commented 1 month ago

can you make it quadriple with putting stamp in cig pack, cig pack in a box, a box in a backpack and then backpack on a player?

deltanedas commented 1 month ago

yes