search

space-wizards / space-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
MIT License
2.74k stars 3.48k forks source link

Missing Inhand Sprites MegaIssue™ #33386

Open TiniestShark opened 1 week ago

TiniestShark commented 1 week ago

Description

There's many items in the game currently lacking any form of Inhand sprites and just appear invisible when held. While not exactly a high priority, fixing and adding inhands to many of these will help with general immersion and visibility.

This is by no means entirely comprehensive (I am one human being) and if there's any I missed, please let me know. Some items were grouped together that could be solved with a generic inhand for their particular category. (I'm also not including items there are already open or already merged PRs for)

I'll update this as PRs are added, Food/Drinks/Plants will be their own issue at some point (Just assume its all of them)

Item Groups:

Clothing:

Dishes/Utencils:

Instruments:

Materials:

Medical:

Plushies/Toys:

Tools/Devices:

Trash/Scrap:

Syndicate/Criminal Items:

Weapons/Ammo:

Other:

Errant-4 commented 1 week ago

Please add #31788

TiniestShark commented 1 week ago

Please add #31788

Added. Muburu's working on them currently I believe but still useful as a reference point.

onesch commented 5 days ago

Hello, should I create a pull request for each element separately or take some ready-made bundle and create a pull request?

Flareguy commented 5 days ago

Hello, should I create a pull request for each element separately or take some ready-made bundle and create a pull request?

It's up to you. Considering inhands are pretty small and specific in nature, I would say it's fine (and even encouraged) to do several at once, especially if they are related in some way. I definitely wouldn't take on the whole list at once or anything, though; The bigger your PR, the more likely it is that something will need to be changed, or that someone else will be working on it.

Flareguy commented 5 days ago

Also, to anyone looking at this: I would highly recommend looking for sprites from other SS13 codebases to see if they have suitable inhands before you make them. A lot of the time, SS14 just seems to have.... not ported the original inhand sprites, for no discernible reason. The health analyzer and bola come to mind here.

You can use scrubby iconsearch to take a quick search for what you are looking for. Just be mindful that you'll need to actually find what commit the sprite is in yourself, alongside ensuring that the sprite fits the artstyle.