spaceandtimelabs / sxt-proof-of-sql

Space and Time | Proof of SQL
Other
2.74k stars 96 forks source link

refactor!: modify `ProofExpr::result_evaluate` to return `ColumnarValue` and remove `table_length` as arg #357

Open iajoiner opened 3 weeks ago

iajoiner commented 3 weeks ago

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

In order to make ProofPlans composable it is necessary to allow one or more ProofPlans as the input to another. As such it is a great idea to remove table_length as an argument in ProofPlan::result_evaluate which in turn requires removal in ProofExpr.

What changes are included in this PR?

iajoiner commented 3 weeks ago

This PR replaced https://github.com/spaceandtimelabs/sxt-proof-of-sql/pull/334