spaceandtimelabs / sxt-proof-of-sql

Space and Time | Proof of SQL
Other
2.74k stars 96 forks source link

fix!: address NITs in PR #361 #367

Closed iajoiner closed 2 weeks ago

iajoiner commented 2 weeks ago

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

Rationale for this change

Since I had auto-merge on NITs didn't get addressed. I promised to file a PR to resolve them today and hence I do now.

What changes are included in this PR?

iajoiner commented 2 weeks ago

Note that this is a breaking change since ProofPlan::is_empty was public

iajoiner commented 2 weeks ago

https://github.com/spaceandtimelabs/sxt-proof-of-sql/actions/runs/11786476589/job/32829840774?pr=367 This doesn't work. I'm undoing the change to compactify the code base.

github-actions[bot] commented 2 weeks ago

:tada: This PR is included in version 0.44.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: