Closed iajoiner closed 2 weeks ago
Note that this is a breaking change since ProofPlan::is_empty
was public
https://github.com/spaceandtimelabs/sxt-proof-of-sql/actions/runs/11786476589/job/32829840774?pr=367 This doesn't work. I'm undoing the change to compactify the code base.
:tada: This PR is included in version 0.44.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!
is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh
.Rationale for this change
Since I had auto-merge on NITs didn't get addressed. I promised to file a PR to resolve them today and hence I do now.
What changes are included in this PR?
UnimplementedTestAccessor
which is no longer usedProofPlan::is_empty
which is only used inVerifiableQueryResult
by inliningquery_proof_test.rs
andverifiable_query_result_test.rs
Existing tests should pass.