spaceandtimelabs / sxt-proof-of-sql

Space and Time | Proof of SQL

Other

2.74k stars 96 forks source link

refactor!: replace output of `result_evaluate` and `final_round_evaluate` of `ProofPlan` with `Table` #371

Closed iajoiner closed 2 weeks ago

iajoiner commented 2 weeks ago

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

[x] The PR title and commit messages adhere to guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md. In particular ! is used if and only if at least one breaking change has been introduced.
[x] I have run the ci check script with source scripts/run_ci_checks.sh.

Rationale for this change

To make ProofPlans composable it is more natural for us to return Tables in result_evaluate and final_round_evaluate in ProofPlan.

What changes are included in this PR?

replace output of result_evaluate and final_round_evaluate of ProofPlan with Table
add Table::columns, ProvableQueryResult::new_from_table to simplify the code
Yes.

github-actions[bot] commented 2 weeks ago

:tada: This PR is included in version 0.46.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: