spaceandtimelabs / sxt-proof-of-sql

Space and Time | Proof of SQL

Other

2.74k stars 96 forks source link

refactor!: replace `DataAccessor` in `ProofPlan` with `IndexMap` #372

Closed iajoiner closed 1 week ago

iajoiner commented 2 weeks ago

Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.

Please go through the following checklist

[x] The PR title and commit messages adhere to guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md. In particular ! is used if and only if at least one breaking change has been introduced.
[x] I have run the ci check script with source scripts/run_ci_checks.sh.

Rationale for this change

This is the next step in making ProofPlan composable. Let's centralize fetching of table maps using DataAccessor to query_proof.rs.

What changes are included in this PR?

See above.

Are these changes tested?

Existing tests do pass.

github-actions[bot] commented 1 week ago

:tada: This PR is included in version 0.48.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: