[x] I have run the ci check script with source scripts/run_ci_checks.sh.
[x] PR #380 has been merged.
Rationale for this change
When ProofPlans compose it makes no sense to have table_length in VerificationBuilder. Instead it becomes necessary to record each and every instance of length used for one_eval and pass the info to the verifier.
What changes are included in this PR?
remove VerificationBuilder::table_length
generalize one eval from input_length and output_length to arbitrary lengths
add singleton_one_evaluation to SumcheckMleEvaluations
add one_evaluation_lengths in FinalRoundBuilder to collect the lengths
add consumption of the lengths in VerificationBuilder
add TableEvaluation
add one_eval as an arg to ProofExpr::verifier_evaluate
return TableEvaluation in ProofPlan::verifier_evaluate
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
When
ProofPlans compose it makes no sense to havetable_lengthinVerificationBuilder. Instead it becomes necessary to record each and every instance of length used for one_eval and pass the info to the verifier.What changes are included in this PR?
VerificationBuilder::table_lengthinput_lengthandoutput_lengthto arbitrary lengthssingleton_one_evaluationtoSumcheckMleEvaluationsone_evaluation_lengthsinFinalRoundBuilderto collect the lengthsVerificationBuilderTableEvaluationone_evalas an arg toProofExpr::verifier_evaluateTableEvaluationinProofPlan::verifier_evaluateYes.