Local/Built-in image proxy

[DEVTomatoCake]

Currently, there's support for the Imagor image proxy. However, not everyone might be able to run or install it everywhere.

This PR adds a local image proxy which can be configured using the cdn_imagorServerUrl config. Currently, it has to be configured as <Base instance URL>/imageproxy.

1. Hash is supported so external users cannot use the proxy with different URLs
2. URL format is compatible with Imagor/Thumbor
3. Resizing is supported using the following fallbacks:
   1. Try sharp (requires C binaries for build)
   2. Try jimp (pure JS, added as optional dependency)
   3. Nothing, image is returned as-is

Discussion

(Doesn't have to be on GitHub, Spacebar/Discord is also possible.)

Code

• [ ] Can those @ts-expect-errors be fixed in a better way?
• [ ] Re: ^, currently, if jimp is installed, L153 is fine with the @ts-expect-error comment. If it isn't, TS complains about the directive being unused. How can this be fixed?

Concept

• [ ] I've currently limited the maximum Content-Length value to 10 MiB to prevent big files from overloading the server. Does this make sense? Is it better to, instead of waiting for the connection to finish, check the headers once they're received and instantly cancel the connection? Or does this not matter at all, and the limit should be removed completely?
• [ ] In which cases would the proxy be enabled after all? Should it be enabled only if cdn_imagorServerUrl includes /imageproxy?

Config

• [ ] Which kind of configs would be required for this? Suggestions:
  • [ ] Maximum file proxy size
  • [ ] Proxy timeout (currently set to 5 seconds)
  • [x] Cache-Control header client cache duration

[MaddyUnderStars]

I don't believe that this is in scope for spacebar, and it has additional performance considerations. Using Imagor makes more sense to me, as it's a dedicated tool written in a more performant language.

[MaddyUnderStars]

You don't need to close it if you want to wait for what the others have to say. @Puyodead1 @TheArcaneBrony

[TheArcaneBrony]

I don't believe this is out of scope for Spacebar? Besides, I don't think performance considerations are that important. For those looking for better performance, Imagor seems to remain available as an option?

• Rory

[DEVTomatoCake]

Imagor seems to remain available as an option?

Yes, it should still be possible to use Imagor and that should be preferred too, but this PR helps if you cannot use Imagor yet.

[Puyodead1]

honestly idfk, it seems like it could be useful

[MaddyUnderStars]

And I've been outvoted! @DEVTomatoCake If you can fix the conflicts, I'll merge it