search

spacebarchat / server

Spacebar server - A reimplementation of the Discord.com backend, built with Typescript and love
https://spacebar.chat
GNU Affero General Public License v3.0
1.49k stars 250 forks source link

Make channel ID optional when replying #1145

Closed DEVTomatoCake closed 4 months ago

DEVTomatoCake commented 4 months ago

This makes guild_id and channel_id optional when sending a message for compatibility, e.g. discord.js fails to use replies otherwise.

TS complains about some properties being missing so it was suggested to simply add @ts-expect-error and be done with it 🤷

MaddyUnderStars commented 4 months ago

Could you regen the schema for this pr and then I'll merge

MaddyUnderStars commented 4 months ago

Why close it? You just needed to merge and regen the schema haha

DEVTomatoCake commented 4 months ago

Why close it? You just needed to merge and regen the schema haha

Because it didn't let me merge due to a non-existing conflict in the schemas file?

MaddyUnderStars commented 4 months ago

You wouldn't be able to do it in the web UI. if you started a merge in cli and then regened the schema before committing it would've been fine

DEVTomatoCake commented 4 months ago

That's what I did, I've tried it in CLI but nope