spacebarchat / server

Spacebar server - A reimplementation of the Discord.com backend, built with Typescript and love
https://spacebar.chat
GNU Affero General Public License v3.0
1.48k stars 251 forks source link

Channels inside category won't persist position change #1204

Open Puyodead1 opened 2 months ago

Puyodead1 commented 2 months ago

Describe the bug the response from a PATCH of a channels position shows the correct position, but a GET after shows the previous position

To Reproduce Steps to reproduce the behavior:

  1. GET a channel /api/channels/1006657100824309439 and notice the position
  2. PATCH the channel and change the position {position: 0} and notice the position in the response
  3. Resend a GET for the channel and notice the position is the same as it was in step 1, the change in step 2 did not persist however a gateway event is emitted with the proper position

Expected behavior The position property is updated and persists

Console Logs N/A

System Information (please complete the following information): Official Instance

Env and Software info

Additional context Pretty sure this is related to #1100

edit: this applies to channels inside a category.