Closed dank074 closed 1 week ago
The CI failed eslint seemingly because the disabled rules are running? Could you have a look at that for me please?
Is this just copy paste'd from #1231 ?
Is this just copy paste'd from #1231 ?
No I ran the migration script myself. Cyber mentioned he had committed these changes but they were not in its own PR
The CI failed eslint seemingly because the disabled rules are running? Could you have a look at that for me please?
The disabled rules aren't the ones throwing the errors. These are the currently disabled rules:
"no-mixed-spaces-and-tabs": "off",
"@typescript-eslint/no-inferrable-types": "off", // Required by typeorm
"@typescript-eslint/no-var-requires": "off", // Sometimes requred by typeorm to resolve circular deps
and the CI is erroring with the below ones:
73:39 error A `require()` style import is forbidden @typescript-eslint/no-require-imports
Error: 74:18 error A `require()` style import is forbidden @typescript-eslint/no-require-imports
Error: 214:24 error A `require()` style import is forbidden @typescript-eslint/no-require-imports
/home/runner/work/server/server/src/api/util/utility/EmbedHandlers.ts
Error: 103:11 error 'e' is defined but never used @typescript-eslint/no-unused-vars
Error: 136:11 error 'e' is defined but never used @typescript-eslint/no-unused-vars
Going to try to see what's causing it.
Would you prefer that I turn these two rules off, or that I add eslint disable directives to the lines causing problems?
Edit: I added the rules to the disabled list. Let me know if you want me to do the latter instead
Sorry for the long wait and the incorrect reply lol yes this is fine. Thanks a lot
While attempting to commit I got the following error message:
This PR updates the eslint config to use the new flat config format