spacedriveapp / spacedrive

Spacedrive is an open source cross-platform file explorer, powered by a virtual distributed filesystem written in Rust.
https://spacedrive.com
GNU Affero General Public License v3.0
31.46k stars 930 forks source link

[MOB-98] Rename, delete, & more #2506

Closed ameer2468 closed 4 months ago

ameer2468 commented 4 months ago

This PR does the following:

Notes:

There's currently issues with the Watcher which I believe Arnab is working on, some updates are not being reflected correctly.

Frame 1
linear[bot] commented 4 months ago

MOB-98 Rename & Delete support

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **spacedrive-landing** | ⬜️ Ignored ([Inspect](https://vercel.com/spacedrive/spacedrive-landing/CjLDXV6j7nRPaXGDue9Y17Af8haN)) | [Visit Preview](https://spacedrive-landing-git-mob-98-rename-delete-support-spacedrive.vercel.app) | | May 27, 2024 0:25am | | **spacedrive-web** | ⬜️ Ignored ([Inspect](https://vercel.com/spacedrive/spacedrive-web/9CG9369LreE6bPWVtBHZkHhNBYNr)) | [Visit Preview](https://spacedrive-web-git-mob-98-rename-delete-support-spacedrive.vercel.app) | | May 27, 2024 0:25am |
utkubakir commented 4 months ago

is CI job relevant here?

ameer2468 commented 4 months ago

is CI job relevant here?

I just fixed the test after running it locally. Also finally fixed the annoying warning message that you would see on initial render in onboarding and in the app.

utkubakir commented 4 months ago

is CI job relevant here?

I just fixed the test after running it locally. Also finally fixed the annoying warning message that you would see on initial render in onboarding and in the app.

How? What was it lol

I am not a fan of these multiple useEffects to be honest, those functions are supposed to only run once on the app start but that might not be the case here

ameer2468 commented 4 months ago

is CI job relevant here?

I just fixed the test after running it locally. Also finally fixed the annoying warning message that you would see on initial render in onboarding and in the app.

How? What was it lol

I am not a fan of these multiple useEffects to be honest, those functions are supposed to only run once on the app start but that might not be the case here

That's what the warning was about. You cannot run that code during the initialization of the App. The reason is it should only be run when buildInfo data is present. It's to prevent it from running during the rendering phase, and therefore they should be in a useEffect.

In that case, there's no harm in using effects, as that's what it should have been in the start.

https://stackoverflow.com/questions/62336340/cannot-update-a-component-while-rendering-a-different-component-warning