search

spacedriveapp / spacedrive

Spacedrive is an open source cross-platform file explorer, powered by a virtual distributed filesystem written in Rust.
https://spacedrive.com
GNU Affero General Public License v3.0
31.46k stars 930 forks source link

Pinned app icon in taskbar is lost after every update in Windows 10 #2522

Open zaaakher opened 4 months ago

zaaakher commented 4 months ago

Describe the bug

I have SD pinned in my taskbar and I noticed every time I update the app, the icon in the taskbar is lost image

So I have to unpin it and open SD again and pin it to the taskbar again. I've been doing this after every update.

Reproduction

  1. Be in Windows 10
  2. Pin SD to the taskbar
  3. Update SD (either from an in-app prompt or via a new .msi file)
  4. Notice the icon in the taskbar is lost

Expected behavior

The SD icon in the pinned taskbar should remain even after updating the app

image

Platform and versions

Windows 10 Pro (Build 19045.4291)
pnpm: v9.1.3
cargo: n/a
rustc: n/a

Stack trace

No response

Additional context

No response

HeavenVolkoff commented 3 months ago

Hun... this is weird, the taskbar icon should just be a shortcut to our .lnk file, which is present after every update afaik. Perhaps the installer is doing something unexpected in Windows, causing it to lose the shortcut reference. I will need to look more into this, Unfortunately, I don't have access to a Windows machine at the moment. Maybe @ameer2468 can test this? @zaaakher, do you happen to know if this issue also occurs in Windows 11?

zaaakher commented 3 months ago

@HeavenVolkoff Could this warning be related?

Unfortunately I don't have access to a Windows 11. Only Windows 10 Pro and macOS Ventura

HeavenVolkoff commented 3 months ago

@HeavenVolkoff Could this warning be related? Possibly. However if the problem is in the installer it may be an underlining issue with tauri builder, as it handles building our releases and packaging them into installers.