Implement extra DMX Clients

spacemanspiff2007 / PyArtNet

"Python wrappers for the Art-Net protocol to send DMX over Ethernet"

GNU General Public License v3.0

67 stars 13 forks source link

Implement extra DMX Clients #18

Closed Breina closed 1 year ago

Breina commented 1 year ago

Not sure if you're up for it, but it can't hurt to try.

Separate animation logic from protocol logic
Change date format to ISO 8601
Implement KiNet (thanks @jjhuff)
Implement e1.31 sACN (thanks @RichUncleCody)
Thread is started automatically, no need to manually .start()

I know the repo is named after ArtNet, but I'm using your lib in my HA branch and would like it to have some more compatibility. I like your channel-width support and animation curves, prefer to not have to re-implement that separately.

Noticed your repo maintains a high standard; I did my best to match it. Please let me know how I did! :)

Breina commented 1 year ago

That should be all for now, would love to have this included into the 0.9.0 release.

Breina commented 1 year ago

Thanks for the feedback! I'll rework.

spacemanspiff2007 commented 1 year ago

I'm all up for more features but time is short atm.

I know the repo is named after ArtNet, but I'm using your lib in my HA branch and would like it to have some more compatibility. I like your channel-width support and animation curves, prefer to not have to re-implement that separately.

I'd love to have more options but I'm currently very busy. So if you want these things working in the next couple of weeks I'd suggest you implement them for yourself and not wait for the PRs to be merged. If you have time I'll gladly look at the things and we'll get them merged.

Also I think it makes sense to split things in multiple PRs, especially the new protocol support.

Breina commented 1 year ago

Alright, I'll split the PR's up and close this one. I'll work on my own repo for the time being, no worries!

Thanks for taking the time anyway!

Breina commented 1 year ago

Created #20 #21 and #22 instead