Make all links abs - Githubissues

spacemeshos / protocol

This repo contains the Spacemesh protocol specifications and related documentation

http://protocol.spacemesh.io/

Apache License 2.0

37 stars 13 forks source link

Make all links abs #42

Closed avive closed 3 years ago

avive commented 4 years ago

Changed all links to abs to make the sidebar worked. So the pattern for links in mining folder is mining/foo.md - not great but should work ok for now.

lrettig commented 4 years ago

So the downside to doing this is that the links no longer work inline here in GitHub, which is kind of a shame. It might be worth trying to come up with something that works in both places. Let me think about it a little.

avive commented 4 years ago

Isn't that okay? the github files are the source and the rendering is on the protocol site. Not super comfortable while you view a file in github but the site is where we want devs to browse these - no?

lrettig commented 4 years ago

My working assumption has been that people are as likely to view these on GitHub as they are on the protocol site...

lrettig commented 4 years ago

Our options are:

deal with broken links on at least one platform
ditch the sidebar entirely
find a better tool for rendering these
hack the existing tool?

avive commented 3 years ago

fixed and can be closed as site moved fro docsify to docusuarus framework.