search

spacepy / dbprocessing

Automated processing controller for heliophysics data
5 stars 4 forks source link

Document output_interface_version and newest_version of inspector table #104

Open jtniehof opened 2 years ago

jtniehof commented 2 years ago

Another one from #102. The output_interface_version column of inspector is weird. Inspectors shouldn't have output versions. This should be figured out...maybe we do nothing with it, and it's another database update. Similarly it doesn't look like we use newest_version. These might be from originally treating inspectors "exactly like" codes. This needs to be figured out, documented, and maybe a database update rolled out.

OS, Python version, and dependency version information:

Linux-4.15.0-163-generic-x86_64-with-Ubuntu-18.04-bionic
sys.version_info(major=2, minor=7, micro=17, releaselevel='final', serial=0)
sqlalchemy=1.1.11

Version of dbprocessing

102 , i.e. 1d5a938ed6666e4da3069d13707f57db650715e7 or jtniehof/dbprocessing:document_tables

Closure condition

This issue should be closed when appropriate documentation describing this functionality (not just the column) is merged, and/or removing the columns from the database (with appropriate migration support.)

balarsen commented 2 years ago

output_interface_version is a funny one. In process it was meant to be the output number, in the inspector I think it was there to make sure that the inspector only found the right version. But my memory is a bit fuzzy.

jtniehof commented 2 years ago

That's what I was wondering, if output_interface_version was there to support us having different inspectors based on the API version. It's a funny name in the inspector context, of course.