Open jtniehof opened 2 years ago
I agree with
My gut feeling says there should be only one of these two mechanisms, but maybe we have a "primary" instrument and "others". This is probably going to involve a db migration and some code checking to make sure all uses the same mechanism.
Another from #102. There is both an
instrumentproductlink
table, implying instruments and products are a many-to-many, and aninstrument_id
column inproduct
, implying each product only has one instrument. I haven't gone digging deeply to figure out which is actually used when doing, say, a reprocess by instrument.My gut feeling says there should be only one of these two mechanisms, but maybe we have a "primary" instrument and "others". This is probably going to involve a db migration and some code checking to make sure all uses the same mechanism.
OS, Python version, and dependency version information:
Version of dbprocessing
102 , i.e. 1d5a938ed6666e4da3069d13707f57db650715e7 or jtniehof/dbprocessing:document_tables
Closure condition
This issue should be closed when a PR is merged with the mapping approach chosen, code updated (with tests), database migration included, and any documentation updates.