search

spacetelescope / calcos

Calibration for HST/COS.
https://hst-docs.stsci.edu/cosdhb/chapter-3-cos-calibration
3 stars 27 forks source link

Upgrade python version regtests #234

Closed stscirij closed 8 months ago

stscirij commented 8 months ago

This PR replaces #231. Many of the changes in this PR had already been pushed to the master branch in other PRs by @zacharyburnett. I ran this branch on the calcos developer tests instance and found a couple of issues that were fixed. Current successful run is at https://plwishmaster.stsci.edu:8081/job/RT/job/Calcos-Developers-Pull-Requests/5/.

There are still deprecation warnings that will be resolved in a future PR.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a9bee81) 87.63% compared to head (409ead2) 87.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #234 +/- ## ======================================= Coverage 87.63% 87.64% ======================================= Files 17 17 Lines 1391 1392 +1 ======================================= + Hits 1219 1220 +1 Misses 172 172 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stscirij commented 8 months ago

Minimum python version is 3.9, so we should test under it @zacharyburnett The last line in the python-testing.yaml specifies the py3-devdeps-xdist environment, which includes numpy 2.0, so is expected to fail until we deal with the numpy 2.0 issues