search

spacetelescope / drizzle

A package for combining dithered images into a single image
https://spacetelescope-drizzle.readthedocs.io/en/latest/
Other
51 stars 26 forks source link

Bjg drizzle rtd #112

Closed braingram closed 1 year ago

braingram commented 1 year ago

Another attempt based off of: https://github.com/spacetelescope/drizzle/pull/111 @zacharyburnett @nden @mcara Would you check if this correctly built all the docs?

closes #98 and closes #111

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
drizzle/doblot.py 100.00%

:loudspeaker: Thoughts on this report? Let us know!.

zacharyburnett commented 1 year ago

The docs for this PR built successfully on RTD and are hosted at https://spacetelescope-drizzle--112.org.readthedocs.build/en/112/; @mcara @nden could you check that these are complete when you have a minute?

braingram commented 1 year ago

I don't know why the sys.path modification was there. It might be possible to import drizzle prior to the path modification if the path modification is required for some other reason but I did not try this.

Should I open this PR or does it make more sense to include the change in one of the other PRs?

zacharyburnett commented 1 year ago

I don't know why the sys.path modification was there. It might be possible to import drizzle prior to the path modification if the path modification is required for some other reason but I did not try this.

Should I open this PR or does it make more sense to include the change in one of the other PRs?

you could potentially change the base branch (the branch being merged into) to one on another PR

or alternatively make these changes on another PR (if you have review access I think you can push to that branch on another person's fork)

braingram commented 1 year ago

I don't know why the sys.path modification was there. It might be possible to import drizzle prior to the path modification if the path modification is required for some other reason but I did not try this. Should I open this PR or does it make more sense to include the change in one of the other PRs?

you could potentially change the base branch (the branch being merged into) to one on another PR

or alternatively make these changes on another PR (if you have review access I think you can push to that branch on another person's fork)

Thanks!

I tried pushing to your fix_docs branch and got a "Permission denied" error so what I propose is:

Does that sound like a good plan?

braingram commented 1 year ago

@mcara if it's easier to merge this PR and close #98 and #111 I don't have any objections (I don't have permissions to merge this). I believe the commits captured the contributions from @zacharyburnett and @nden. Thanks all for work fixing this :)