spacetelescope / jdaviz

JWST astronomical data analysis tools in the Jupyter platform

https://jdaviz.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

142 stars 74 forks source link

Imviz: Selected data in Layers menu should follow display #743

Open pllim opened 3 years ago

pllim commented 3 years ago

Workflow to reproduce the problem:

Fire up Imviz.
Load 2 images.
Note that the second image is now shown but when you click on Layers menu, it still give you the options of the first image. As a result, when you change, say the percentile, you don't see the display changes until you blink back to the first image. This is very confusing.

Desired behavior: The selected data in Layers should reflect what is actually shown.

TODO

[ ] Patch upstream at glue-viz/glue-jupyter#244
[ ] If patch is accepted upstream, we need to pin to new release with that patch.

:cat:

pllim commented 2 years ago

Was brought up again in https://github.com/spacetelescope/jdaviz/issues/1428

pllim commented 2 years ago

@orifox brought this up again. So maybe we should bump the priority...

kecnry commented 2 years ago

Note that the labels in #1465 are sorted in layer order. Is this issue for the data-menu, the layer dropdowns in plugins, or both?

pllim commented 2 years ago

When I originally wrote this, I specifically meant the "data selected" field in the Layers menu. Now this also extends to similar field we have since added to other plugins.

I know other people also have asked for Data menu ordering but personally, I don't find that as important. (And I think it has its own JIRA ticket somewhere.)