The current NOSTR value used in the maker utils is incompatible with some archive_catalog nvarchar entries. Although this value likely shouldn't ever end up in the archive it prevents adding corresponding minLength keywords to the schemas (to check these nvarchars during schema validation).
This PR set's a new NOSTR value of ?. This was chosen as the smallest nvarchar value is 2 for visit_file_activity.
romancal also includes some of these default values in the doctests. https://github.com/spacetelescope/romancal/pull/1419 is needed before this PR can be merged. EDIT: romancal PR is merged, rerunning regtests but will open this for review in case there are requested changes
news fragment change types...
- ``changes/.feature.rst``: new feature
- ``changes/.bugfix.rst``: fixes an issue
- ``changes/.doc.rst``: documentation change
- ``changes/.removal.rst``: deprecation or removal of public API
- ``changes/.misc.rst``: infrastructure or miscellaneous change
The current
NOSTRvalue used in the maker utils is incompatible with some archive_catalog nvarchar entries. Although this value likely shouldn't ever end up in the archive it prevents adding correspondingminLengthkeywords to the schemas (to check these nvarchars during schema validation).This PR set's a new
NOSTRvalue of?. This was chosen as the smallestnvarcharvalue is 2 for visit_file_activity.meta.filenamerequires a different valuenoneassource_catalogwill use this value for some unit tests: https://github.com/spacetelescope/romancal/blob/96af8bbc6a6dafd48d1beb251b5209d9da875ca1/romancal/source_catalog/source_catalog_step.py#L151 Which then leads to a failure since it attempts to write to "?".romancal also includes some of these default values in the doctests. https://github.com/spacetelescope/romancal/pull/1419 is needed before this PR can be merged. EDIT: romancal PR is merged, rerunning regtests but will open this for review in case there are requested changes
Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/10966346784 show same failures as main: https://github.com/spacetelescope/RegressionTests/actions/runs/10998102193
This PR is a requirement for https://github.com/spacetelescope/rad/pull/448
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)romancalregression test with this branch installed ("git+https://github.com/<fork>/roman_datamodels@<branch>")news fragment change types...
- ``changes/Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #388 +/- ## ========================================== + Coverage 97.56% 97.68% +0.12% ========================================== Files 30 37 +7 Lines 2788 3372 +584 ========================================== + Hits 2720 3294 +574 - Misses 68 78 +10 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.