Closed braingram closed 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.56%. Comparing base (
1e16207
) to head (78b4664
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
This PR adds an "always" filter for
ValidationWarning
s at the end of the warning filter list.This addresses an issue where for an interactive python session (using the standard python REPL) only the first call to "validate" for a particular validation error will result in a warning:
This is a byproduct of the "default" python warning filter which for a particular warning based on message, category and line number will only show the warning the first time. This PR adds an "always" for
ValidationWarning
to override this behavior but adds it to the end of the filter list so that a user can still control these warnings (for example by using-Werror
to turn all warnings into errors).I can't sort out how we can test this due to a couple factors:
I'm going to open this for review knowing that this doesn't include a test for change. I am ok with that given the scope of the change but please let me know if anyone sorts out a way to test this.
Regtests running: https://github.com/spacetelescope/RegressionTests/actions/runs/11979991732
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)jwst
regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>"
)news fragment change types...
- ``changes/