search

spacetelescope / stsci.imagemanip

STScI image manipulation.
Other
0 stars 1 forks source link

Do we still need this package? #9

Open pllim opened 5 years ago

pllim commented 5 years ago

It has one function. And why not use https://docs.scipy.org/doc/scipy/reference/generated/scipy.interpolate.interp2d.html instead of this one?

pllim commented 5 years ago

@SaOgaz reported that astrodrizzle still uses this function. @mcara and @hack, how about moving this into drizzlepac and retire this package?

mcara commented 5 years ago

I did not even know this... Where do you people find these gems?

Looking at the comments in the code, p * a[i] + q * a[i+1] - I am not sure this can even be called bi-linear. Maybe I missed something...

mcara commented 5 years ago

In any case, this is definitely a candidate for scipy's interpolation methods depending on how it is being used in astrodrizzle. I (or @stsci-hack) will need to look into this.

jhunkeler commented 5 years ago

Where do you people find these gems?

$ grep -ER "(from|import).*stsci\.imagemanip" drizzlepac/
drizzlepac/drizzlepac/stisData.py:from stsci.imagemanip import interp2d
mcara commented 5 years ago

Treasure hunters....

pllim commented 5 years ago

Holy grail

mcara commented 5 years ago

That was the look that I saw on @jhunkeler 's face today!

jhunkeler commented 5 years ago

When I told @pllim this package was in still in production...

marion_with_knife

mcara commented 5 years ago

Just a reminder for myself to look into this.

SaOgaz commented 5 years ago

@mcara bump :D

mcara commented 5 years ago

Such a weird way of doing interpolation: https://github.com/spacetelescope/stsci.imagemanip/blob/2b766bfef94f33b1e9920e6f4ccb5dcdc43aa5e7/src/bilinearinterp.c#L33, i.e., only integer scaling is allowed... I'll look into this @SaOgaz

mcara commented 5 years ago

This package can be retire once drizzlepac>3.0.0 is released. It is no longer a dependency of the drizzlepac's master since https://github.com/spacetelescope/drizzlepac/pull/227

CC: @stsci-hack @jhunkeler