Installation issue: LvArray @ 0.2.1 testTensorOpsNoSize.cpp max size failure

tldahlgren commented 3 years ago

Steps to reproduce the issue

I am building the software in the Spack RADIUSS Cloud CI and the unitTests/CMakeFiles/testTensorOps.dir/testTensorOpsOneSize.cpp unit test build is failing with the error below. The CDash output can be found at https://cdash.spack.io/viewBuildError.php?buildid=162186.

...
     864    [ 71%] Built target testArrayView_moveNoTouch
     865    [ 71%] Building CXX object unitTests/CMakeFiles/testTensorOps.dir/t
            estTensorOpsNoSize.cpp.o
     866    cd /tmp/root/spack-stage/spack-stage-lvarray-0.2.1-qtrp34efjzifs4th
            4uce7v3345bbe6qj/spack-build-qtrp34e/unitTests && /usr/bin/g++ -DGT
            EST_HAS_DEATH_TEST=0 -DtestTensorOps_EXPORTS -I/tmp/root/spack-stag
            e/spack-stage-lvarray-0.2.1-qtrp34efjzifs4th4uce7v3345bbe6qj/spack-
            src/unitTests/../src -I/tmp/root/spack-stage/spack-stage-lvarray-0.
            2.1-qtrp34efjzifs4th4uce7v3345bbe6qj/spack-build-qtrp34e/include -i
            system /home/software/radiuss/__spack_path_placeholder__/__spack_pa
            th_placeholder__/__spack_path_placeholder__/__spack_path_placeholde
            r__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_p
            ath_placeholder__/__spack_path_placeholder__/__spack_path_placehold
            er__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_
            path_placeholder__/__spack_path_placeholder__/__spack_path_placehol
            der__/__spack_path_placeholder__/__spack_path_placeholder__/__spack
            _path_placeholder__/__spack_path_placeholder__/__s/linux-ubuntu18.0
            4-x86_64/gcc-7.5.0/blt-0.3.6-l2icfuyphvkwcnao4xfrdqf6vi4jisft/third
            party_builtin/googletest-master-2020-01-07/googletest/include -isys
            tem /home/software/radiuss/__spack_path_placeholder__/__spack_path_
            placeholder__/__spack_path_placeholder__/__spack_path_placeholder__
            /__spack_path_placeholder__/__spack_path_placeholder__/__spack_path
            _placeholder__/__spack_path_placeholder__/__spack_path_placeholder_
            _/__spack_path_placeholder__/__spack_path_placeholder__/__spack_pat
            h_placeholder__/__spack_path_placeholder__/__spack_path_placeholder
            __/__spack_path_placeholder__/__spack_path_placeholder__/__spack_pa
            th_placeholder__/__spack_path_placeholder__/__s/linux-ubuntu18.04-x
            86_64/gcc-7.5.0/blt-0.3.6-l2icfuyphvkwcnao4xfrdqf6vi4jisft/thirdpar
            ty_builtin/googletest-master-2020-01-07/googletest -isystem /home/s
            oftware/radiuss/__spack_path_placeholder__/__spack_path_placeholder
            __/__spack_path_placeholder__/__spack_path_placeholder__/__spack_pa
            th_placeholder__/__spack_path_placeholder__/__spack_path_placeholde
            r__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_p
            ath_placeholder__/__spack_path_placeholder__/__spack_path_placehold
            er__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_
            path_placeholder__/__spack_path_placeholder__/__spack_path_placehol
            der__/__spack_path_placeholder__/__s/linux-ubuntu18.04-x86_64/gcc-7
            .5.0/camp-0.1.0-kblcdklscvi7fnwcght5dhyjq5omzu5v/include -isystem /
            home/software/radiuss/__spack_path_placeholder__/__spack_path_place
            holder__/__spack_path_placeholder__/__spack_path_placeholder__/__sp
            ack_path_placeholder__/__spack_path_placeholder__/__spack_path_plac
            eholder__/__spack_path_placeholder__/__spack_path_placeholder__/__s
            pack_path_placeholder__/__spack_path_placeholder__/__spack_path_pla
            ceholder__/__spack_path_placeholder__/__spack_path_placeholder__/__
            spack_path_placeholder__/__spack_path_placeholder__/__spack_path_pl
            aceholder__/__spack_path_placeholder__/__s/linux-ubuntu18.04-x86_64
            /gcc-7.5.0/raja-0.13.0-cwvapask6hesyg5jtpqdvxifyjvbj7yn/include -Wa
            ll -Wextra   -Werror  -Wall -Wextra -Wpedantic -pedantic-errors -Ws
            hadow -Wfloat-equal -Wcast-align -Wcast-qual  -O3 -g -DNDEBUG -fPIE
             -fopenmp -std=c++14 -MD -MT unitTests/CMakeFiles/testTensorOps.dir
            /testTensorOpsNoSize.cpp.o -MF CMakeFiles/testTensorOps.dir/testTen
            sorOpsNoSize.cpp.o.d -o CMakeFiles/testTensorOps.dir/testTensorOpsN
            oSize.cpp.o -c /tmp/root/spack-stage/spack-stage-lvarray-0.2.1-qtrp
            34efjzifs4th4uce7v3345bbe6qj/spack-src/unitTests/testTensorOpsNoSiz
            e.cpp
     867    In member function 'void LvArray::testing::BufferTestWithRealloc_se
            tCapacity_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_
             = LvArray::MallocBuffer<int>]':
  >> 868    cc1plus: error: 'void* __builtin_memset(void*, int, long unsigned i
            nt)': specified size 18446744073709551416 exceeds maximum object si
            ze 9223372036854775807 [-Werror=stringop-overflow=]
  >> 869    cc1plus: error: 'void* __builtin_memset(void*, int, long unsigned i
            nt)': specified size 18446744073709551416 exceeds maximum object si
            ze 9223372036854775807 [-Werror=stringop-overflow=]
     870    [ 72%] Linking CXX executable ../tests/testArrayView_udcToViewConst
...
==> [2021-08-09-20:10:45.673562] Installing lvarray from source
==> [2021-08-09-20:10:45.673676] spack install arguments: ['spack', '-d', '-v', 'install', '--keep-stage', '--require-full-hash-match', '--no-check-signature', '--cdash-upload-url', 'https://cdash.spack.io/submit.php?project=Spack+Testing', '--cdash-build', 'lvarray@0.2.1%gcc@7.5.0 arch=linux-ubuntu18.04-x86_64 (RADIUSS)', '--cdash-site', 'Cloud Gitlab Infrastructure', '--cdash-buildstamp', '20210809-2010-RADIUSS', '--no-add', '-f', '/builds/spack/spack/jobs_scratch_dir/reproduction/lvarray.yaml']
==> [2021-08-09-20:16:53.660269] spack install exited 1
...

Information on your system

Reporting results from Spack Cloud CI so see above snippets for a bit more information, which ran on the uo-instinct runner. Hopefully the links will stay around a while.

Additional information

@corbett5

spack-build-out.txt lvarray.yaml.txt

Note: I am selecting check boxes in "General Information" where the roughly equivalent information is (hopefully) provided by alternative file(s)/links.

General information

[X] I have run spack debug report and reported the version of Spack/Python/Platform
[X] I have run spack maintainers <name-of-the-package> and @mentioned any maintainers
[X] I have uploaded the build log and environment files
[X] I have searched the issues of this repo and believe this is not a duplicate

corbett5 commented 3 years ago

Thanks! I'll take a look at it, probably specific to GCC 7.

tldahlgren commented 3 years ago

FYI. Just replaced the build output with the equivalent from the raw output.

corbett5 commented 3 years ago

Ok I've got a PR up that fixes the issue. After merging it do you need a new release?

corbett5 commented 3 years ago

@tldahlgren I merged the PR, do you need a new release (and associated Spack update)?

tldahlgren commented 3 years ago

@tldahlgren I merged the PR, do you need a new release (and associated Spack update)?

Hi @corbett5. Great! Thanks. I'm working off develop so I think I should be fine.

tldahlgren commented 3 years ago

@tldahlgren I merged the PR, do you need a new release (and associated Spack update)?

Hi @corbett5. Great! Thanks. I'm working off develop so I think I should be fine.

Hmm. My PR (#25321 ) did depend on the above recommendation of using lvarray ~tests. I'm generally going off of whatever is the preferred version for a package.

corbett5 commented 3 years ago

The lvarray.yamlfile you have has tests: true, which is the default.

tldahlgren commented 3 years ago

@tldahlgren I merged the PR, do you need a new release (and associated Spack update)?

@corbett5 Hi Ben. Is it too late to take you up on a new release and Spack update? I had someone point out to me that I really shouldn't be having the RADIUSS Cloud CI jobs running against the develop version. (See #25530 )

corbett5 commented 3 years ago

Sure, it might take me a week to get around to though.

tldahlgren commented 3 years ago

Sure, it might take me a week to get around to though.

Great! Keep me posted. And thank you.

corbett5 commented 3 years ago

It took me two weeks, sorry for the delay.

https://github.com/spack/spack/pull/25950

spack / spack