search

sparanoid / slimpack

Lightweight Jetpack. Super-fast performance without modules that require contracting WordPress.com.
http://sparanoid.com/work/slimpack/
17 stars 1 forks source link

jjloomis jetpack 4.0.2 updates #15

Closed jjloomis closed 8 years ago

jjloomis commented 8 years ago

Hey @sparanoid. Here are the Jetpack updates through 4.0.2. I updated everything except the Slimpack-specific files (class.jetpack.php, functions.opengraph.php, site-icons.php). Tested locally and everything seems to be working fine.

Note: Jetpack 4.0.2 no longer has the following files in its root folder:

class.media-extractor.php

class.media-summary.php

I did make and test a version of Slimpack that does not include these files (not part of this PR, though). I had to also remove lines 51 and 52 from your slimpack.php file in order for it to work (these lines reference the class.media-extractor.php and class.media-summary.php files). Everything seems to work with these files and lines removed, but I did not include these changes in this PR. I figure you're the guy to make this type of higher level decision.

I can, however, do another PR with these changes. Let me know if you want me to send that along.

sparanoid commented 8 years ago

@jjloomis sorry for my this late reply, really busy these days.

Just looked at the source code of Jetpack 4.0.2(3), it seems that class.media-extractor.php and class.media-summary.php have been moved into _inc/lib/ directory. Everything seems to "work" because of the class_exists check in class.jetpack-twitter-cards.php.

jjloomis commented 8 years ago

Cool. Thanks @sparanoid.