search

sparkfun / OpenLog_Artemis

The OpenLog Artemis is an open source datalogger the comes preprogrammed to automatically log IMU, GPS, serial data, and various pressure, humidity, and distance sensors. All without writing a single line of code!
https://www.sparkfun.com/products/15846
Other
88 stars 47 forks source link

Added SCD30 FRC calibration to config menu #181

Closed hotstick closed 9 months ago

hotstick commented 1 year ago

This code exposes setForcedRecalibrationFactor() for the SCD30 in the device config menu level in order to apply FRC using CO2 calibration gas between 400ppm and 2000ppm.

PaulZC commented 1 year ago

Hi Chris (@hotstick ),

This is useful - thanks!

In COMPILE_BINARY.md, your path for the ICM20948 library isn't what most users will have. The ICM20948 library lives here: https://github.com/sparkfun/SparkFun_ICM-20948_ArduinoLibrary . The original path is correct for most users. Please undo that change.

We like Pull Requests to target the release_candidate branch (see CONTRIBUTING.md). But I can change the branch before merging.

Best wishes, Paul

PaulZC commented 1 year ago

Thanks Chris,

I'm going to hold off merging this for a while. There may be a new version of the Apollo3 core coming, and I'm keen to use that for any new firmware builds if possible.

Best wishes, Paul

hotstick commented 1 year ago

No worries, I look forward to seeing the new Apollo3 core!

PaulZC commented 9 months ago

Hi Chris (@hotstick ),

Apologies for the very long delay! Merging...

(The new version of the core never appeared... So v2.6 will be built using v2.2.1 of the core as normal.)

Best wishes, Paul