Compile errors fix

[YuyaIwata]

Thanks for great sensor board and Arduino library. In using the library, I found several errors and warning in compile log, so I tried to fix them below. The line number is from cpp file.

• Line 356 to 393
  • In MODE_TWO, it might be using the array bpmSenArrTwo is correct, but there are bpmSenArr. Which size of array are not equal, so overflow would be occurred.
• Line 544
  • Bit shift is not working.
  • Corresponding to above, I found bit mask is wrong in the header file.
• Line 611
  • The array revNum has not initialized. Which would be needs specify array size and initial value.
• Others
  • Deleted unused variables.
  • Fixed comparing with under zero in unsigned value.
  • Fixed comparing with over the maximum value of type.
  • Fixed implicit type casting in return to be explicit type casting.

that's all.

P.S. Sorry for my poor English.

[edspark]

This looks really great, I do have one request. It seems that you hadn't quite pulled in the latest changes before you made the pull request. Do you mind updating your branch with these changes, so that I can pull them in? Thanks!

[alexmstahl]

Thank you Yuya Iwata and thank you Elias Santistevan!

I have noticed the same issues regarding bpmSenArrTwo and uninitialized/unused variables, and am very grateful that you are also working on this.

One more question, about the functions to check Sensor Hub version number, Bootloader version number, and Algorithm version number. In my tests the Algorithm version is always 0.0.0. The others look correct. It would be interesting to know if this is the same for you.

Regards

Alex

On Apr 29, 2020, at 11:39 AM, Elias Santistevan notifications@github.com wrote:

This looks really great, I do have one request. It seems that you hadn't quite pulled in the latest changes https://github.com/sparkfun/SparkFun_Bio_Sensor_Hub_Library/commit/8d30befefaa7d47b96e7964e3b9ef68977ab40a3 before you made the pull request. Do you mind updating your branch with these changes, so that I can pull them in? Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sparkfun/SparkFun_Bio_Sensor_Hub_Library/pull/5#issuecomment-621390549, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCUHFH56K7EEXLXHLW7OMTRPBX6XANCNFSM4MTL54EQ.

[edspark]

Thanks @alexmstahl, much appreciated! I somehow didn't see that you had made fixes to your pull request.

[YuyaIwata]

Thanks for the merge. All fixes to the pull request were made by me (@YuyaIwata).